developit / developit/react-router-4-test

Switch does not work

Abierto
#7 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
35
Forks
7
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

**Edit: Just realized pull request /pull/2 is exactly about this**

react-router's [Switch](https://reacttraining.com/react-router/web/api/Switch) looks for a function `Children.forEach` which isn't there. If I try to shim it by
```
Children.forEach = (c, f) => c.forEach(f);
```
then it looks for a function `React.isValidElement`, When it is shimmed as `const isValidElement = (e) => true;`, Switch starts to look for the component's props but the VNode doesn't have it, so Children.forEach should be

```
Children.forEach = (C, f) => {
const compat = C.map(c => ({...c, props: { path: c.attributes.path }}));
return compat.forEach(f);
}
```

which finally results in a `props.match` object returned from Switch. However, one would rather import `preact-compat` instead of rewriting it.

Don't know how this would be solved other than using `preact-compat` when `Switch` or other complex routing elements are needed.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.