developit / developit/preact-shadow-root

Support Preact X

Abierto
#6 2 comentarios 4 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
73
Forks
6
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

- `this.base` is `undefined` at `componentDidMount`, so `this.shadow` never gets initialized.
- `props.children[0]` is `undefined`, since `children` isn’t always an array anymore.
- The third argument to `render()` should be removed, as per the Preact X upgrade docs.

I run the following replacements on my bundle as a workaround:

```js
// Hacks to make `preact-shadow-root` work with Preact 10.
"this.base&&this.base.parentNode": "this.__P",
"o.children[0],": "o.children,",
"this.shadow.firstChild": "undefined",
```

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.