developit / developit/microbundle
Maybe should compile `node_modules` with babel when use inline dependencies
- Langage dominant
- JavaScript
- Étoiles
- 8.1k
- Forks
- 358
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
Now microbundle is use `exclude: 'node_modules/**'` to create babel config, I think it's reasonable when not inline dependencies.
But if use inline dependencies... this options maybe is weird?
```typescript
// foo/bar.js (in node_modules)
module.exports = {a: ()=>console.log('1')}
```
```typescript
// My module
import abc from 'foo/bar.js';
window.de = abc
export const b = () => {
console.log('2')
}
```
Then add `foo` module to `devDependencies`.
Result:
```typescript
window.de={a:()=>console.log("1")};var o=function(){console.log('2')};export{o as b};
```
If i use inline dependencies mean **i hope it's part of mine module**, my modules arrow function has compile (it's right) but `foo` modules has nothing change.
Maybe should not set `exclude: 'node_modules/**'` when use inline dependencies?
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Piste de recherche
Start by reproducing the inline-dependency example using foo/bar.js and the My module, then trace how the Babel config applies exclude: 'node_modules/**'. Compare the output for the dependency and the local arrow function. Done means inline dependencies receive the intended Babel compilation without changing the behavior for non-inlined dependencies.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- javascript
- Domaine
- build-system, tooling
- Type d'issue
- Bug
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 35/100