developit / developit/htm

Improve transpilation error handling for missing closing tags

Aperta
#168 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
debugging proposal
Lingua principale
JavaScript
Stelle
9k
Fork
181
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Consider this sample code, which accidentally omits a closing tag.

```js
import htm from 'htm'
const h = (type, props, ...children) => ({type, props, children});
const html = htm.bind(h)

console.log(JSON.stringify(html`

Hello, world!`));
```

In this case, the user intended to include a closing tag `

`, and so the user's desired logged result is `{"type":"h1","props":null,"children":["Hello, world!"]}`

Transpile `htm` away using this script.

shell script

```sh
#!/bin/sh -ex

rm -rf babel-htm-errors
mkdir babel-htm-errors
cd babel-htm-errors
npm init -y
npm i -D @babel/cli @babel/core babel-plugin-htm
cat < .babelrc
{
"plugins": [
["htm", {
"pragma": "h"
}]
]
}
EOF
cat < index.js
import htm from 'htm'
const h = (type, props, ...children) => ({type, props, children});
const html = htm.bind(h)

console.log(JSON.stringify(html\`

Hello, world!\`));
EOF
npx babel index.js > output.mjs
node output.mjs
```

Expected: Transpilation should fail with an error.

Actual: The `html` line transpiles to:

```js
console.log(JSON.stringify("Hello, world!"));
```

The `

` tag is silently dropped.

(Note that this error behavior is different from the runtime behavior of htm with mismatching closing tags; see issue #166.)

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.