devcontainers / devcontainers/cli

devcontainer features test command inside a container with mounted docker socket -> problems with /tmp

Aperta
#923 2 commenti 4 reazioni 0 assegnatari Vedi su GitHub
feature-request
Lingua principale
TypeScript
Stelle
3k
Fork
457
Merge medio
13h 17m
PR unite (30g)
6

Descrizione

The `devcontainer features test` (especially for scenarios) creates everything needed in a directory in `/tmp`. When the container is created, this folder is mounted inside the container (probably for the additional files and the verifying `.sh` file).

This leads to problems when the devcontainer-cli and the test are running inside a container with a mounted docker socket.
The problem is that the `/tmp` with the correct data is in the container and when creating the test-container and mounting the `/tmp`, the `/tmp` from the docker host (outside of the container) is used which does not know the the correct data of course.

I tried to draw this:
```
/ Docker-Host
├── Docker / Docker Socket
├── container with devcontainer cli
│ ├── workspace
│ │ ├── src
│ │ └── test
│ └── tmp (contains the temporary devcontainer spec)
└── tmp (is mounted when the devcontainer is started)
```

In some cases this is easy fixable by mounting `/tmp` from the host to `/tmp` into the container with the devcontainer cli but sometimes (in some CI scenarios), adding additional mounts is not possible.

My suggestion would be to be able to specify the `temporaryPath` where all these files are placed. If this path could be specified, it would at least be possible to use some clever symlinking to achieve the same path inside the container with the cli and from the host.

An alternative would be to not need this mount at all and copy all those files during the build of the container into the container so they are directly available.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.