devcontainers / devcontainers/cli

devcontainer exec does not always propagate SIGTERM to docker exec

Aperta
#888 1 commento 0 reazioni 1 assegnatario Rivendicata da @chrmarti Vedi su GitHub
bug upstream
Lingua principale
TypeScript
Stelle
3k
Fork
457
Merge medio
13h 17m
PR unite (30g)
6

Descrizione

Steps to reproduce:
- Run devcontainer exec without pty, for instance:
```
devcontainer exec --container-id 1234abcdefgh -- sleep infinity > /dev/null 2>&1
```
- Check that on the host machine and inside the container you have infinity sleep process: `ps -auxf |grep "infinity"`
- Interrupt `devcontainer exec` with SIGTERM, i.e. kill the process or just interrupt the terminal.
- Check on the host machine the docker process is gone, but inside the container infinity sleep is dangling.

It seems `docker exec` is terminated without SIGTERM, leading to ungraceful termination.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.