devcontainers / devcontainers/cli

How to specify the default value with colon for localEnv.

Aperta
#719 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
bug
Lingua principale
TypeScript
Stelle
3k
Fork
457
Merge medio
13h 17m
PR unite (30g)
6

Descrizione

Hi DevContainers Team,

The case for me is to set the index url for pip, so what I do is something like

```json
{
...
"remoteEnv": {
"PIP_INDEX_URL": "${localEnv:PIP_INDEX_URL:https://pypi.org/simple}"
}
}
```

I perfer a default value to handle the cases that `PIP_INDEX_URL` does not exist. But it turns out that when the env does not exist, the corresponding env in the vscode context will be set to `https` rather than `https://pypi.org/simple`. Any clues to make it happen?

Seems it is related to the code here:
https://github.com/devcontainers/cli/blob/f7d4c853bf8c284d784173f3e915a34d961b0b55/src/spec-common/variableSubstitution.ts#L85
If I understand correctly, one option could be setting the split limit to 1, and maybe another approach is that we can avoid set the env in the context if the value is empty.

Thanks in advance.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.