devcontainers / devcontainers/cli

Improve experience of publishing Features|Templates to Dockerhub

Open
#476 0 comments 0 reactions 0 assignees View on GitHub
feature-request
Dominant language
TypeScript
Stars
3k
Forks
457
Avg merge
13h 17m
Merged PRs (30d)
6

Description

Reported in the [Dev Container Community Slack](https://github.com/orgs/devcontainers/discussions/3) [**(ref)**](https://github.slack.com/archives/C0431R35H37/p1680402927120119).

Dockerhub has a lot of special cases that this CLI's container registry implementation needs to support. One that I noticed is that the key name in the `~/.docker/config.json` is `"https://index.docker.io/v1/"`. This CLI currently uses this key to map to the published registry name - all other examples omit `https` and don't have any additional path (`v1`). Both of these components will need to be handled when building the URI

This could be lumped into https://github.com/devcontainers/cli/issues/468, as I think this is mostly an auth special case.

Once fixed, add regression testing to https://github.com/devcontainers/cli/blob/main/src/test/container-features/registryCompatibilityOCI.test.ts.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.