devcontainers / devcontainers/cli

Error: --platform or --push not supported w/dockerComposeFile

Abierto
#404 3 comentarios 14 reacciones 0 asignados Ver en GitHub
feature-request
Lenguaje dominante
TypeScript
Estrellas
3k
Forks
457
Merge medio
13 h 17 min
PR fusionados (30 d)
6

Descripción

I noticed that the `ci` project now supports a platform option with the following work https://github.com/devcontainers/ci/pull/175 However, it breaks for me when I use this with `dockerComposeFile`. I can reproduce this locally too with the CLI.

```
(kencollins) - (~/Repositories/lamby-citest) 💎 3.1.3 🔄 main
> devcontainer build --workspace-folder . --image-name test --platform linux/amd64
[16 ms] @devcontainers/cli 0.29.0. Node.js v18.11.0. darwin 21.6.0 x64.
Error: --platform or --push not supported.
at uoe (/Users/kencollins/.nodenv/versions/18.11.0/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:2045:27034)
at async aoe (/Users/kencollins/.nodenv/versions/18.11.0/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:2045:25017)
{"outcome":"error","message":"--platform or --push not supported.","description":"--platform or --push not supported."}
```

Is this an oversight on behalf of the following work where some error handling needs to be removed?

- https://github.com/devcontainers/cli/pull/24
- https://github.com/devcontainers/cli/pull/61

I tracked the error to the following location in the code. Thoughts?

- https://github.com/devcontainers/cli/blob/main/src/spec-node/devContainersSpecCLI.ts#L585-L589

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.