devcontainers / devcontainers/cli

Error: --platform or --push not supported w/dockerComposeFile

Open
#404 3 comments 14 reactions 0 assignees View on GitHub
feature-request
Dominant language
TypeScript
Stars
3k
Forks
457
Avg merge
13h 17m
Merged PRs (30d)
6

Description

I noticed that the `ci` project now supports a platform option with the following work https://github.com/devcontainers/ci/pull/175 However, it breaks for me when I use this with `dockerComposeFile`. I can reproduce this locally too with the CLI.

```
(kencollins) - (~/Repositories/lamby-citest) 💎 3.1.3 🔄 main
> devcontainer build --workspace-folder . --image-name test --platform linux/amd64
[16 ms] @devcontainers/cli 0.29.0. Node.js v18.11.0. darwin 21.6.0 x64.
Error: --platform or --push not supported.
at uoe (/Users/kencollins/.nodenv/versions/18.11.0/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:2045:27034)
at async aoe (/Users/kencollins/.nodenv/versions/18.11.0/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:2045:25017)
{"outcome":"error","message":"--platform or --push not supported.","description":"--platform or --push not supported."}
```

Is this an oversight on behalf of the following work where some error handling needs to be removed?

- https://github.com/devcontainers/cli/pull/24
- https://github.com/devcontainers/cli/pull/61

I tracked the error to the following location in the code. Thoughts?

- https://github.com/devcontainers/cli/blob/main/src/spec-node/devContainersSpecCLI.ts#L585-L589

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.