devcontainers / devcontainers/cli

install.sh wrapper relative link not resolved correctly

未关闭
#1,232 0 条评论 0 个 reaction 已指派 1 人 已被 @V-Subhankar-infy 认领 在 GitHub 查看
主要语言
TypeScript
星标
3k
派生
457
平均合并
13 小时 17 分钟
30 天内合并 PR
6

描述

I'm trying to create a generic install method for a dotfile/software install library I maintain. I want to install a link to the binary in `~/.local/bin/` and keep the devcontainers install under `~/.local/lib/devcontainers/`. The install takes care of this via the `--prefix ~/.local` argument.

The problem is that when I create a relative link called devcontainer from `~/.local/bin` to `~/.local/lib/devcontainers/bin/devcontainer` and then invoke the `devcontainer` executable, the generated bin file resolves the link as a relative link, rather than absolute.

Example install method:
```shell
INSTALL_DIR=$HOME/.local
curl -sSLO https://raw.githubusercontent.com/devcontainers/cli/main/scripts/install.sh
chmod +x install.sh
./install.sh --prefix "${INSTALL_DIR}"/lib/devcontainers
cd "${INSTALL_DIR}"/bin
ln -s ../lib/devcontainers/bin/devcontainer devcontainer
```

Example running `devcontainer` which is already in the PATH of `~/.local/bin/`

```shell
$devcontainer
/home/vasdee/.local/bin/devcontainer: line 18: cd: ../lib/devcontainers/bin: No such file or directory
```

In `~/.local/bin/devcontainer` i believe if the follow link logic preferred the full path option of `readlink`, over the relative (which is the opposite of how it is now) then the issue would be solved....at least for me

```shell
# Resolve the installation directory
# Handle both direct execution and symlinked scenarios
if [ -L "$0" ]; then
# Follow symlink current logic
SCRIPT_PATH="$(readlink "$0" 2>/dev/null || readlink -f "$0" 2>/dev/null || echo "$0")"
# Follow symlink potential fix by preferring the abs path over relative
# SCRIPT_PATH="$(readlink -f "$0" 2>/dev/null || readlink "$0" 2>/dev/null || echo "$0")"
else
SCRIPT_PATH="$0"
fi
```

I am happy to contribute a PR, but am not sure of the history behind this choice and what impact the change might have. I'm looking for guidance in that respect.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。