deezer / deezer/android-sample
Unsafe implementation of the HostnameVerifier interface
- Lenguaje dominante
- Java
- Estrellas
- 42
- Forks
- 25
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
Google now is blocking updates to apps that include libraries that have "unsafe" HostnameVerifier implementations. They seem to pattern match the code so always returning true even from a HostnameVerifier that is only used in a safe context the fact that it always returns true seems to trip the filter.
https://support.google.com/faqs/answer/7188426
> To properly handle hostname verification, change the implementation of your custom HostnameVerifier interface to perform the following actions:
> - If you are using the HostnameVerifier interface, change the implementation of the verify method to return false whenever the hostname of the server does not meet your expectations.
> - If you are using the X509HostnameVerifier interface, change the implementation of the verify methods (variants 1, 2, 3) to raise an SSLException whenever the hostname of the server does not meet your expectations. Ensure that the Exceptions raised within your verify implementation are not caught and suppressed within the method. Suppressing Exceptions in this manner would cause verify to exit normally, leading the app to trust all hostnames.
```java
package com.deezer.sdk.network.b;
...
public class Blues {
...
private static final HostnameVerifier bagpipes = new HostnameVerifier() {
public final boolean verify(String hostname, SSLSession session) {
return true;
}
};
...
private static HttpURLConnection accordion(String var0, String var1, boolean var2) throws IOException {
Object var3;
if (var2) {
((HttpsURLConnection)(var3 = (HttpsURLConnection)(new URL(var0)).openConnection())).setHostnameVerifier(bagpipes);
} else {
var3 = (HttpURLConnection)(new URL(var0)).openConnection();
}
((HttpURLConnection)var3).setRequestProperty("User-Agent", var1);
return (HttpURLConnection)var3;
}
...
}
```
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Línea de trabajo
Busca en el código fuente de Java los usos de HostnameVerifier y setHostnameVerifier y, después, inspecciona el verificador personalizado y la ruta de conexión del accordion que se muestra en el issue. Se considera terminado cuando la implementación ya no confía incondicionalmente en cualquier hostname, sino que aplica las comprobaciones del hostname esperado sin suprimir los fallos de verificación.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- java
- Área
- mobile-dev, networking, security
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 38/100