SetBreakpointsRequestHandler fails when supplied path is using forward slashes

Offen

#318 erstellt am 04.2.2020 3 Kommentare 0 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

@testforstephen arbeitet bereits daran.

Seit 07.2.2020.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Beschreibung

ai-triaged bug enhancement

Description
When a DAP (debug adapter protocol) client sends a setBreakpoints request with a path that contains forward slashes the breakpoint is not set.
The server also (wrongfully?) reports back that the command was executed successfully.

Observed behavior
The code runs without halting at the breakpoint.

Expected behavior
The program should halt at the breakpoint and send a breakpoint event to the DAP client.

Logging with forward slashes (Not working)

Sending: 
{
  "command": "setBreakpoints",
  "arguments": {
    "source": {
      "name": "Hello.java",
      "path": "c:/project/src/main/java/Hello.java"
    },
    "breakpoints": [
      {
        "line": 6
      }
    ],
    "sourceModified": false,
    "lines": [
      6
    ]
  },
  "type": "request",
  "seq": 3
}

Received:
{
  "type": "response",
  "seq": 4,
  "body": {
    "breakpoints": [
      {
        "message": "",
        "line": 6,
        "verified": null,
        "id": 1
      }
    ]
  },
  "command": "setBreakpoints",
  "request_seq": 3,
  "success": true
}

Logging with backward slashes (Working)

Sending: 
{
  "command": "setBreakpoints",
  "arguments": {
    "source": {
      "name": "Hello.java",
      "path": "c:\project\src\main\java\Hello.java"
    },
    "breakpoints": [
      {
        "line": 6
      }
    ],
    "sourceModified": false,
    "lines": [
      6
    ]
  },
  "type": "request",
  "seq": 3
}

Received:
{
  "type": "response",
  "seq": 4,
  "body": {
    "breakpoints": [
      {
        "message": "",
        "line": 6,
        "verified": true,
        "id": 1
      }
    ]
  },
  "command": "setBreakpoints",
  "request_seq": 3,
  "success": true
}

Suggestion
I think the "offending" code is here
This line behaves differently depending if forward or backward slashes have been used.
Maybe replace all forward slashes with backward slashes if we are on windows.
Could be implemented before/after the drive letter fix.

System
Windows 10
DAP Client: emacs with lsp-mode/dap-mode
DAP Server: jdtls (Eclipse language server)

Vorherrschende Sprache: Java
Sterne: 409
Forks: 204
Ø Merge: 1 T. 13 Std.
Gemergte PRs (30 T.): 4

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Erste Schritte

Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
Forken Sie das Repository und arbeiten Sie in einem Branch.
Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus microsoft/java-debug

[WSL] Breakpoints fail to bind when attaching to JVM in WSL2 after Debugger for Java 0.58.3 update; rollback fixes Offen

ai-triaged bug

Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 35/100

microsoft/java-debug#611 · 2 Kommentare · Erstellt am 06.11.2025
Support "Suspend VM" and "Suspend Thread" Breakpoint Modes Offen

ai-triaged enhancement

Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 35/100

microsoft/java-debug#608 · 3 Kommentare · Erstellt am 16.10.2025
Can i start deifferent debug session in one jdt.ls Offen

ai-triaged question

Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 30/100

microsoft/java-debug#597 · 1 Kommentar · Erstellt am 01.8.2025
Debugging in one-line lambdas does not work Offen

ai-triaged bug

Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 25/100

microsoft/java-debug#588 · 1 Kommentar · Erstellt am 01.5.2025
Is Hamcrest a dependency? Offen

ai-triaged question

Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 35/100

microsoft/java-debug#582 · 1 Kommentar · Erstellt am 17.3.2025

Alle Issues in microsoft/java-debug