Dashboard isModified setting for tags

Offen
#703 2 Kommentare 0 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

@jgclark arbeitet bereits daran.

Seit 14.11.2025.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Beschreibung

bug

When you get a few moments, can you have a look at this?

I have a perspective called ALL_ON that has every item enabled and a bunch of tags in it.

Image

About half the time that I switch to this perspective, without making any changes, I see it think it's modified:

Image

Log says:

JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged: Setting perspective.isModified because of changes to settings: 7 keys: showTagSection_#dbwDR, showTagSection_#waiting, showTagSection_@pierce, showTagSection_@kenna, showTagSection_@anique, showTagSection_@bev, showTagSection_@storey :: {
  "showTagSection_#dbwDR": true,
  "showTagSection_#waiting": true,
  "showTagSection_@pierce": true,
  "showTagSection_@kenna": true,
  "showTagSection_@anique": true,
  "showTagSection_@bev": true,
  "showTagSection_@storey": true
}
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: activePerspDefDashboardSettingsWithDefaults['showTagSection_#dbwDR']=undefined vs. sent to save: cleanedSettings['showTagSection_#dbwDR']=true
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: activePerspDefDashboardSettingsWithDefaults['showTagSection_#waiting']=undefined vs. sent to save: cleanedSettings['showTagSection_#waiting']=true
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: activePerspDefDashboardSettingsWithDefaults['showTagSection_@pierce']=undefined vs. sent to save: cleanedSettings['showTagSection_@pierce']=true
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: activePerspDefDashboardSettingsWithDefaults['showTagSection_@kenna']=undefined vs. sent to save: cleanedSettings['showTagSection_@kenna']=true
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: activePerspDefDashboardSettingsWithDefaults['showTagSection_@anique']=undefined vs. sent to save: cleanedSettings['showTagSection_@anique']=true
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: activePerspDefDashboardSettingsWithDefaults['showTagSection_@bev']=undefined vs. sent to save: cleanedSettings['showTagSection_@bev']=true
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: activePerspDefDashboardSettingsWithDefaults['showTagSection_@storey']=undefined vs. sent to save: cleanedSettings['showTagSection_@storey']=true
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: Setting isModified to true for perspective z_ALL_ON
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: Saving perspectiveSettings also

The front-end is sending all the TAG sections as true (which is correct), but the variable activePerspDefDashboardSettingsWithDefaults is not including those TAGs and therefore they don't match. So somewhere/somehow that activePerspDefDashboardSettingsWithDefaults needs to include the TAG sections so that the comparison works properly.

Can you please have a look?

Vorherrschende Sprache
JavaScript
Sterne
204
Forks
82
Ø Merge
22 Std. 27 Min.
Gemergte PRs (30 T.)
3

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus NotePlan/plugins

Alle Issues in NotePlan/plugins

Ähnliche Issues

Weitere Issues zu JavaScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.