dbcli / dbcli/mssql-cli

Improve exception handling in jsonrpcclient

Open
#350 0 comments 0 reactions 0 assignees View on GitHub
area: engineering systems
Dominant language
Python
Stars
1.4k
Forks
191
PR merge metrics
No merged PRs in 30d

Description

The `jsonrpcclient.py` file has two instances of generic exception handling. Generic exception handling breaks PEP 8 and can make debugging issues more difficult, especially since exceptions are suppressed.

Although we are logging exceptions, I recommend re-working this logic. If we choose to keep generic exception handling then we may at least consider simplifying instances of redundant code where repeat logic is used across different exceptions.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.