dbcli / dbcli/mssql-cli

Logger returns NameError in non-interactive mode for Python 2

Abierto
#317 0 comentarios 0 reacciones 0 asignados Ver en GitHub
area: non-interactive bug impact: test reliability
Lenguaje dominante
Python
Estrellas
1.4k
Forks
191
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

`pytest -s tests/test_noninteractive_mode` shows the following warning:
```Exception ignored in:
Traceback (most recent call last):
File "/Users/ellbosch/Repos/mssql-cli/mssqlcli/mssql_cli.py", line 196, in __del__
File "/Users/ellbosch/Repos/mssql-cli/mssqlcli/sqltoolsclient.py", line 90, in shutdown
File "/Users/ellbosch/Repos/mssql-cli/mssqlcli/jsonrpc/jsonrpcclient.py", line 184, in shutdown
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/logging/__init__.py", line 1378, in info
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/logging/__init__.py", line 1514, in _log
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/logging/__init__.py", line 1524, in handle
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/logging/__init__.py", line 1586, in callHandlers
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/logging/__init__.py", line 894, in handle
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/logging/__init__.py", line 1126, in emit
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/logging/__init__.py", line 1116, in _open
NameError: name 'open' is not defined
```

Looks like the logger is referenced post-deconstruction.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Línea de trabajo

Start by running pytest -s tests/test_noninteractive_mode, then inspect mssqlcli/mssql_cli.py at __del__, mssqlcli/sqltoolsclient.py at shutdown, and mssqlcli/jsonrpc/jsonrpcclient.py at its logging call. Confirm the teardown path can run during interpreter deconstruction, and consider the issue done when the test no longer emits the NameError warning.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
python
Área
cli
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
42/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.