dbcli / dbcli/mssql-cli

Logger returns NameError in non-interactive mode for Python 2

Open
#317 0 comments 0 reactions 0 assignees View on GitHub
area: non-interactive bug impact: test reliability
Dominant language
Python
Stars
1.4k
Forks
191
PR merge metrics
No merged PRs in 30d

Description

`pytest -s tests/test_noninteractive_mode` shows the following warning:
```Exception ignored in:
Traceback (most recent call last):
File "/Users/ellbosch/Repos/mssql-cli/mssqlcli/mssql_cli.py", line 196, in __del__
File "/Users/ellbosch/Repos/mssql-cli/mssqlcli/sqltoolsclient.py", line 90, in shutdown
File "/Users/ellbosch/Repos/mssql-cli/mssqlcli/jsonrpc/jsonrpcclient.py", line 184, in shutdown
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/logging/__init__.py", line 1378, in info
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/logging/__init__.py", line 1514, in _log
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/logging/__init__.py", line 1524, in handle
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/logging/__init__.py", line 1586, in callHandlers
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/logging/__init__.py", line 894, in handle
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/logging/__init__.py", line 1126, in emit
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/logging/__init__.py", line 1116, in _open
NameError: name 'open' is not defined
```

Looks like the logger is referenced post-deconstruction.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.