dbcli / dbcli/litecli

Pager options not honored with click>=8.1.8

未关闭
#240 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
symphony:review
主要语言
Python
星标
3.3k
派生
95
PR 合并指标
30 天内没有已合并 PR

描述

Seemingly related to #225

I just installed litecli today using pip, and click was 8.3.0 per the dependency specification excluding 8.1.*

My $PAGER variable is set to `less -iJS` (case-insensitive search, show status column, don't wrap long lines) but I noticed that the output in litecli was not honoring this (there should be an empty first column, long lines are still wrapped, searching for "afghanistan" finds no results).

Image

When I manually downgrade click to 8.1.7 or lower, this works as expected:

Image

(Status column shown [-J], lines are not wrapped [-S], searching for "afghanistan" still finds "AFGHANISTAN" [-i])

8.1.8 is the first "bad" version and this issue has _not_ been fixed in click 8.2.* or 8.3.0.

Can you please update the dependency specifications to use 8.1.7 or lower?
I am not 100% sure but perhaps `click>=4.1,<=8.1.7` would be appropriate.

Thank you!

贡献指南

打开贡献指南

调研方向

首先使用所示的 $PAGER 值,按报告的 Click 版本重现分页器行为,对比 8.1.7 或更低版本与 8.1.8 及更高版本。检查依赖项规范,并验证支持范围排除了分页器选项失效的版本;完成标准是 litecli 支持不区分大小写的搜索、状态列显示以及禁用换行。

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
cli
Issue 类型
缺陷
难度
2/5
预计耗时
1-3 小时
活跃度
停滞
描述清晰度
基本清楚
新手友好度
45/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。