dbcli / dbcli/litecli

Pager options not honored with click>=8.1.8

Open
#240 3 comments 0 reactions 0 assignees View on GitHub
symphony:review
Dominant language
Python
Stars
3.3k
Forks
95
PR merge metrics
No merged PRs in 30d

Description

Seemingly related to #225

I just installed litecli today using pip, and click was 8.3.0 per the dependency specification excluding 8.1.*

My $PAGER variable is set to `less -iJS` (case-insensitive search, show status column, don't wrap long lines) but I noticed that the output in litecli was not honoring this (there should be an empty first column, long lines are still wrapped, searching for "afghanistan" finds no results).

Image

When I manually downgrade click to 8.1.7 or lower, this works as expected:

Image

(Status column shown [-J], lines are not wrapped [-S], searching for "afghanistan" still finds "AFGHANISTAN" [-i])

8.1.8 is the first "bad" version and this issue has _not_ been fixed in click 8.2.* or 8.3.0.

Can you please update the dependency specifications to use 8.1.7 or lower?
I am not 100% sure but perhaps `click>=4.1,<=8.1.7` would be appropriate.

Thank you!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.