dataiku / dataiku/dataiku-api-client-python

dataikuapi/dss/recipe.py : set_code_env fix

Open
#110 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
44
Forks
29
Avg merge
3h 34m
Merged PRs (30d)
2

Description

Hi,

I don't know if the the post I've made on the Community forum has been reviewed yet.
I haven't seen a commit on it (not in the "master" nor the "dss80-set-code-env-mode") so I post an issue here.

The function set_code_env (from the class CodeRecipeSettings) doesn't set the code env but a string :

if code_env is not None: rp["envSelection"] = {"envMode": "EXPLICIT_ENV", "envName": "code_env"}

Should be :

if code_env is not None: rp["envSelection"] = {"envMode": "EXPLICIT_ENV", "envName": code_env}

Hoping I won't trouble your workspace.

Greetings,
Steven

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

In dataikuapi/dss/recipe.py, start at CodeRecipeSettings.set_code_env and compare the envSelection payload with the issue's expected value. Done when the supplied code environment name is used rather than the literal string; no test file is mentioned in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.