darktable-org / darktable-org/lua-scripts
Allow programatically reading / setting output color profile of an image to be exported
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Lua
- Estrellas
- 219
- Forks
- 142
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
Forked from pixls.us thread:
In a script, I'm using the following code to export an image to JPG:
local exporter = dt.new_format("jpeg")
exporter.quality = 95
exporter:write_image(src, dest)
That code is dependent on the export module's output color profile currently selected in the UI. I would like to either force a specific profile (let's say Display P3 RGB), or detect when an invalid profile (for my purpose) is used, to be able to warn the user. My options with the current API are:
-
dt.gui.action("lib/export/profile", 0, "selection", "first", 0.0)+dt.gui.action("lib/export/profile", 0, "selection", "next", 10.0)asDisplay P3 RGBis currently the 11th one displayed; that's hardcoded in colorspaces.c.Pro: Unobtrusive.
Con: Depends on DT internals without their proper representation through the API. If DT profile order ever changes, the script forcefully selects a different profile. -
dt.gui.action("lib/export/profile", 0, "selection", "popup", 0.0)Pro: Doesn't depend on DT internals, user could select their own ICC profiles too.
Con: Obtrusive; user is prompted to the action even if the current settings are correct, they are also asked to select the only correct option. -
Export, then check the resulting file metadata, and error out post factum.
Pro: Unobtrusive.
Con: Suboptimal UX, as I cannot prevent the error from happening, or implement input data validation before triggering the action. Possibly the metadata won't be there if export doesn't have the EXIF. -
Export outside of DT
Pro: Total control over the output.
Con: Needs an intermediary export in DT to a format that isn't sensitive to color profile (does it even exist?) to retain changes done to the RAW in DT, like cropping etc.
All of the workarounds above would not be needed if the Lua API allowed for:
- Setting output color profile in
dt_imageio_module_format_t.write_image, or - Reading/setting output color profile of
dt_lua_image_t(this might be through #414). I could then useimage settingsprofile in export, which is the first option in the combobox, or - Reading/setting the combobox options by their name in export's profile combobox (the
item:prefix doesn't seem to work there)
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Start with the Lua API entry points dt.new_format("jpeg") and dt_imageio_module_format_t.write_image, then review the referenced colorspaces.c profile ordering and issue #414. Compare the requested ways to read or set the export profile and define completion as a script being able to select or inspect the output profile without relying on UI ordering.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- lua
- Área
- api
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100