danielgtaylor / danielgtaylor/python-betterproto
ruff check in outputfile_compiler breaks when proto field comments end in quote marks
- Vorherrschende Sprache
- Python
- Sterne
- 1.8k
- Forks
- 234
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
### Summary
ruff check in outputfile_compiler breaks when proto field comments end in quote marks
### Reproduction Steps
```proto
message Test {
// something, for example "bug"
string what = 1;
}
```
### Expected Results
It works.
### Actual Results
Ruff errors out with "SyntaxError: Expected a statement" on the string that looks like `"""something, for example "bug""""`.
### System Information
n/a
### Checklist
- [x] I have searched the issues for duplicates.
- [x] I have shown the entire traceback, if possible.
- [x] I have verified this issue occurs on the latest prelease of betterproto which can be installed using `pip install -U --pre betterproto`, if possible.
Beitragsleitfaden
Rechercherichtung
Start by locating the outputfile_compiler code path and reproducing the issue with the provided proto snippet. Verify that generated output containing a field comment ending in quote marks passes ruff check without a SyntaxError.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- python
- Bereich
- tooling
- Issue-Typ
- Bug
- Schwierigkeit
- 2/5
- Geschätzter Aufwand
- 1-3 Stunden
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 45/100