danielgtaylor / danielgtaylor/python-betterproto

ruff check in outputfile_compiler breaks when proto field comments end in quote marks

Open
#671 0 comments 0 reactions 0 assignees View on GitHub
bug investigation needed
Dominant language
Python
Stars
1.8k
Forks
234
PR merge metrics
No merged PRs in 30d

Description

### Summary

ruff check in outputfile_compiler breaks when proto field comments end in quote marks

### Reproduction Steps

```proto
message Test {
// something, for example "bug"
string what = 1;
}
```

### Expected Results

It works.

### Actual Results

Ruff errors out with "SyntaxError: Expected a statement" on the string that looks like `"""something, for example "bug""""`.

### System Information

n/a

### Checklist

- [x] I have searched the issues for duplicates.
- [x] I have shown the entire traceback, if possible.
- [x] I have verified this issue occurs on the latest prelease of betterproto which can be installed using `pip install -U --pre betterproto`, if possible.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.