danielgtaylor / danielgtaylor/python-betterproto

Add casing to from_dict method

Open
#660 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
1.8k
Forks
234
PR merge metrics
No merged PRs in 30d

Description

### Summary

from_dict method did not support casing

### What is the feature request for?

The core library

### The Problem

When using `to_dict` method I can pass case, but for `from_dict` method only safe_snake_case is available, It looks like some inconsistent behavior

### The Ideal Solution

As i understand `safe snake case` is not necessarily needs to be safe, so replacing it with any casting method would be safe

### The Current Solution

Just use snakecase in dict

Contributor guide

Open the contributing guide

Research direction

Start by locating the core library entry points for from_dict and to_dict, then compare how the existing case argument is handled by to_dict with the fixed safe_snake_case behavior in from_dict. Confirm the intended casing options and identify the relevant tests or test location before defining done as consistent casing support for both methods.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend-api-design
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.