cspotcode / cspotcode/node-source-map-support

`retrieveFile` interprets empty string as "no response"

未關閉
#33 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
JavaScript
星號
16
分支
4
PR 合併指標
30 天內沒有已合併 PR

描述

https://github.com/cspotcode/node-source-map-support/blob/817f84b2820e7395a274379cf80e79930e15d3b2/source-map-support.js#L147

https://github.com/cspotcode/node-source-map-support/blob/817f84b2820e7395a274379cf80e79930e15d3b2/source-map-support.js#L129-L135

If a file is empty, `retrieveFile` can return empty string. This is falsey, and today is erroneously interpreted as "no response," causing subsequent `retrieveFile` handlers to be invoked.

We can change `retrieveFile` to allow returning `undefined` and fix the logic to interpret empty string as empty file.

*Note:* Is a breaking change.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。