cspotcode / cspotcode/node-source-map-support
`retrieveFile` interprets empty string as "no response"
Open
- Dominant language
- JavaScript
- Stars
- 16
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/cspotcode/node-source-map-support/blob/817f84b2820e7395a274379cf80e79930e15d3b2/source-map-support.js#L147
https://github.com/cspotcode/node-source-map-support/blob/817f84b2820e7395a274379cf80e79930e15d3b2/source-map-support.js#L129-L135
If a file is empty, `retrieveFile` can return empty string. This is falsey, and today is erroneously interpreted as "no response," causing subsequent `retrieveFile` handlers to be invoked.
We can change `retrieveFile` to allow returning `undefined` and fix the logic to interpret empty string as empty file.
*Note:* Is a breaking change.
Contributor guide
Assessment
This issue has not been assessed yet.