crunchloop / crunchloop/devcontainer

BuildKit detection probe in runtime/docker (design §13.2)

Abierto
#8 0 comentarios 0 reacciones 0 asignados Ver en GitHub
area/runtime enhancement
Lenguaje dominante
Go
Estrellas
5
Forks
0
Merge medio
6 h 17 min
PR fusionados (30 d)
15

Descripción

Per design/runtime.md §13.2: prefer BuildKit if available, fall back to classic. Today `runtime/docker/build.go` calls `ImageBuild` without setting `Version`, so we get whatever the daemon defaults to.

### Plan

- Probe `Info.BuilderVersion` (or check for `buildkit` capabilities) at `docker.New()`
- Cache result on `*Runtime`
- In `BuildImage`, set `opts.Version = build.BuilderBuildKit` when supported
- Fall back to classic with a warning if a buildkit-only construct (e.g. `# syntax=...`) appears in the user's Dockerfile but the daemon has no buildkit

### Why now

Our generated feature dockerfile starts with `# syntax=docker/dockerfile:1.4`. Classic ignores this as a comment so today's flow works, but cache mounts and other syntax-1.4 features won't apply unless buildkit is on.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.