conductor-oss / conductor-oss/python-sdk

WaitTask base class sets wrong inputParameter key 'wait_until' instead of 'until'

Offen Anfängerfreundlich
#426 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
bug
Vorherrschende Sprache
Python
Sterne
104
Forks
42
Ø Merge
2 T. 1 Std.
Gemergte PRs (30 T.)
3

Beschreibung

## Summary

Tested against: **Conductor OSS 3.32.0-rc.9**

`WaitTask.__init__(wait_until=...)` sets the inputParameter key `"wait_until"`,
but the Conductor server reads `"until"`. The task is accepted at registration
but never triggers at runtime — the workflow stays RUNNING indefinitely.

## Reproduction

```python
from conductor.client.workflow.task.wait_task import WaitTask

t = WaitTask("my_wait", wait_until="2024-01-01 00:00 UTC")
print(t.input_parameters)
# {'wait_until': '2024-01-01 00:00 UTC'} ← WRONG KEY
```

Start a workflow containing this task. The task status stays `IN_PROGRESS`
forever — the server never sees `"until"` so the condition is never evaluated.

## Root cause

`wait_task.py` line 26:
```python
self.input_parameters = {"wait_until": wait_until} # wrong key
```

Server constant (`Wait.java`):
```java
public static final String UNTIL_INPUT = "until";
```

## Fix

```python
self.input_parameters = {"until": wait_until}
```

Note: the `WaitUntilTask` subclass already uses the correct key `"until"` and
is unaffected. Only `WaitTask.__init__()` called directly with `wait_until=` is broken.

## Verified against

Conductor server **3.32.0-rc.9**, confirmed via live test in
[conductor-oss/conductor-test-harness](https://github.com/nthmost-orkes/conductor-test-harness):
task remained `RUNNING` after 10 s with `wait_until` key; `WaitUntilTask` with
`until` key completed immediately.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Rechercherichtung

Start with wait_task.py at line 26 and compare WaitTask.__init__() with the unaffected WaitUntilTask subclass and the server’s Wait.java constant. Done means direct WaitTask use emits the server-recognized input parameter and no longer leaves the task running indefinitely; verify the serialized parameters and workflow behavior described in the reproduction.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
python
Bereich
backend
Issue-Typ
Bug
Schwierigkeit
1/5
Geschätzter Aufwand
Unter einer Stunde
Aktivitätsstatus
Ruhig
Klarheit
Klar beschrieben
Anfängerfreundlichkeit
82/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.