compas-dev / compas-dev/compas_fab

Remove Legacy

Open
#426 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
137
Forks
47
PR merge metrics
No merged PRs in 30d

Description

I think it is time to remove the following 4 functions in favor of compas.Data. Especially for the compas_fab 1.0 release.

- `write_data_to_json`
- `read_data_from_json`
- `write_data_to_pickle`
- `read_data_from_pickle`

https://github.com/compas-dev/compas_fab/blob/main/src/compas_fab/utilities/file_io.py#L44-L111

Does anyone have reservations?

Contributor guide

Open the contributing guide

Research direction

Start in src/compas_fab/utilities/file_io.py at the four listed functions, then search the repository for their callers and existing uses of compas.Data. Confirm the release impact and remove the legacy functions only when no required references remain; update affected tests or callers as indicated by that search.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.