common-workflow-language / common-workflow-language/schema_salad
need test for "check_exists does not follow redirects"
Aperta
- Lingua principale
- Python
- Stelle
- 86
- Fork
- 64
- Merge medio
- 19h 24m
- PR unite (30g)
- 19
Descrizione
schema_salad.Fetcher.check_exists does a head() check on URLs. It turns out that the Python requests library does not follow redirects by default on HEAD requests. As a result, blanket redirects such as from http->https will be considered "success" even if it would be a 404 after the redirect.
The fix is to add the allow_redirects flag.
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.