common-workflow-language / common-workflow-language/cwljava
parsing CWL v1.0 & v1.1
- Lingua principale
- Java
- Stelle
- 16
- Fork
- 8
- Merge medio
- 4h 5m
- PR unite (30g)
- 7
Descrizione
Recently, we integrated cwljava v1.0 into Dockstore, and during testing, we found some workflows that cause the parser to throw. In our webservice, we use our own preprocessor to combine the various component CWL files into one big CWL represented by Maps/Lists, and parse it with cwljava here:
https://github.com/dockstore/dockstore/blob/67f4547e771864cafacdc1c92fa7bd47261e32da/dockstore-webservice/src/main/java/io/dockstore/webservice/languages/CWLHandler.java#L364
The following workflows cause `loadDocument` to throw a `ValidationException`:
https://github.com/ICGC-TCGA-PanCancer/OxoG-Dockstore-Tools/tree/master
primary descriptor: /oxog_varbam_annotate_wf.cwl
https://github.com/h3abionet/h3agatk/tree/1.0.1
primary descriptor: /workflows/GATK/GATK-complete-WES-Workflow-h3abionet.cwl
The first workflow contains a `SchemaDefRequirement` and the parser appears to have trouble parsing the type references (`TumourType.yaml#TumourType` etc). When I change the type references to `int`, the workflow successfully parses.
Judging from exception message, the second workflow seems to be failing for a different reason, but I haven't pinpointed what, exactly. It is possible that it's not valid, but a cursory inspection didn't turn up any problems.
The exception messages are pretty big, so I put them and some stack trace info in the comments.
Please let me know if you need any more info. Thanks!
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Valutazione
Questa issue non è ancora stata valutata.