commitizen / commitizen/cz-cli

Let the adapters depend on inquirer

Ouverte
#249 9 commentaires 1 réaction 0 personnes assignées Voir sur GitHub
Langage dominant
JavaScript
Étoiles
17.5k
Forks
566
Merge moyen
8 h 16 min
PR mergées (30 j)
1

Description

Instead of us supplying inquirer to the adapters, I think that it would be very nice if they could depend on it themselves. Then they can update that dependency at their own discretion instead of being dependent on the main module.

Currently you can choose to be compatible with either commitizen > 2.8.0, or with versions < 2.8.0 since we upgraded inquirer which broke the api. Since this has already been updated as well in conventional-changelog, I think it's to late to revert the update here.

The problem I'm facing as an adapter author is that if I upgrade, I need to go around and tell everyone at the office to update to a newer version of commitizen. I also must upgrade all of the repos that uses our internal adapter at the same time. Otherwise we will have some repos that works in one version, and some that works in other.

Basically this is quite a lot of pain and I think that we should move towards letting the adapters depend on their dependencies separately.

Also, there might even be a benefit to let our interface to the adapters be completely language agnostic. We could just execute the file, and use the output as the commit message.

@jimthedev I know that you are very busy but if you could just quickly answer if you are in favour of this, then I could implement it 👌

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Aucun fichier ni test n’est nommé. Commencez par retracer comment cz-cli fournit inquirer aux adapters et comment la sortie des adapters devient un message de commit. Définissez la limite de dépendance des adapters et le comportement d’exécution indépendant de la langue avant de déterminer la portée de l’implémentation.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
javascript, node.js
Domaine
cli, developer-experience
Type d'issue
Fonctionnalité
Difficulté
5/5
Temps estimé
Plus d'une semaine
Activité
À l'abandon
Clarté
À clarifier
Accessibilité débutants
25/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.