commercetools / commercetools/commercetools-sync-java

[Hactoberfest] Limit the number of retries on concurrency modification exceptions

Open
#197 0 comments 0 reactions 0 assignees View on GitHub
Hacktoberfest
Dominant language
Java
Stars
40
Forks
41
PR merge metrics
No merged PRs in 30d

Description

**Situation**
Currently on concurrency modification exceptions the sync retries with no limit until there is no error. See:
https://github.com/commercetools/commercetools-sync-java/blob/7cacc37ef8a1412f9bf300ba08000c108db81b4f/src/main/java/com/commercetools/sync/commons/BaseSync.java#L115-L124

**Complication**
It causes unnecessary api calls if the platform returns 409 - ConcurrentModificationException for the requests.

**Resolution**
Limit the number of retries on concurrency modification exceptions.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.