commercetools / commercetools/commercetools-sdk-java-v2
Consistency in CtOkHttp4Client ExecutorService usage
- Vorherrschende Sprache
- Java
- Sterne
- 47
- Forks
- 21
- Ø Merge
- 9 T. 13 Std.
- Gemergte PRs (30 T.)
- 4
Beschreibung
Hey.
We're evaluating the usage of Virtual Threads with `Executors.newVirtualThreadPerTaskExecutor();`.
I've noticed that there's an inconsistency in the usage of `ExecutorService executor` in `CtOkHttp4Client`:
```java
public CtOkHttp4Client(final ExecutorService executor) {
super(executor);
okHttpClient = clientBuilder.get().dispatcher(createDispatcher(executor, MAX_REQUESTS, MAX_REQUESTS)).build();
}
public CtOkHttp4Client(final ExecutorService executor, final BuilderOptions options) {
super(executor);
okHttpClient = options.plus(clientBuilder.get().dispatcher(createDispatcher(MAX_REQUESTS, MAX_REQUESTS)))
.build();
}
public CtOkHttp4Client(final ExecutorService executor, final int maxRequests, final int maxRequestsPerHost) {
super(executor);
okHttpClient = clientBuilder.get()
.dispatcher(createDispatcher(executor, maxRequests, maxRequestsPerHost))
.build();
}
public CtOkHttp4Client(final ExecutorService executor, final int maxRequests, final int maxRequestsPerHost,
final BuilderOptions options) {
super(executor);
okHttpClient = options
.plus(clientBuilder.get().dispatcher(createDispatcher(executor, maxRequests, maxRequestsPerHost)))
.build();
}
```
The second constructor doesn't reuse the passed `executorService` when creating the dispatcher, while all others that get the same argument do.
It just so happens that this one would be the ideal one for us 🤠.
Is there a reason for this, or is it an oversight?
Besides this, any thoughts or recommendations on using the Virtual Threads executor with the SDK?
Maybe you've already done experimenting on your end? Is the SDK prone to [Thread Pinning](https://docs.oracle.com/en/java/javase/21/core/virtual-threads.html#GUID-704A716D-0662-4BC7-8C7F-66EE74B1EDAD)?
Thanks.
Beitragsleitfaden
Für dieses Repository ist kein Beitragsleitfaden indexiert
Rechercherichtung
Beginne damit, CtOkHttp4Client zu lokalisieren und die vier im Issue gezeigten Konstruktoren zu vergleichen, insbesondere wie createDispatcher den ExecutorService erhält. Überprüfe, ob der BuilderOptions-Konstruktor den übergebenen Executor konsistent verwenden sollte, und füge Tests hinzu oder aktualisiere sie, falls das Repository relevante Tests enthält; abgeschlossen ist die Aufgabe, wenn die Konstruktoren ein konsistentes, verifiziertes Executor-Verhalten aufweisen.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- java
- Bereich
- api
- Issue-Typ
- Bug
- Schwierigkeit
- 2/5
- Geschätzter Aufwand
- 1-3 Stunden
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100