commercetools / commercetools/commercetools-sdk-java-v2

Consistency in CtOkHttp4Client ExecutorService usage

Open
#569 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
47
Forks
21
Avg merge
9d 13h
Merged PRs (30d)
4

Description

Hey.

We're evaluating the usage of Virtual Threads with `Executors.newVirtualThreadPerTaskExecutor();`.

I've noticed that there's an inconsistency in the usage of `ExecutorService executor` in `CtOkHttp4Client`:

```java

public CtOkHttp4Client(final ExecutorService executor) {
super(executor);
okHttpClient = clientBuilder.get().dispatcher(createDispatcher(executor, MAX_REQUESTS, MAX_REQUESTS)).build();
}

public CtOkHttp4Client(final ExecutorService executor, final BuilderOptions options) {
super(executor);
okHttpClient = options.plus(clientBuilder.get().dispatcher(createDispatcher(MAX_REQUESTS, MAX_REQUESTS)))
.build();
}

public CtOkHttp4Client(final ExecutorService executor, final int maxRequests, final int maxRequestsPerHost) {
super(executor);
okHttpClient = clientBuilder.get()
.dispatcher(createDispatcher(executor, maxRequests, maxRequestsPerHost))
.build();
}

public CtOkHttp4Client(final ExecutorService executor, final int maxRequests, final int maxRequestsPerHost,
final BuilderOptions options) {
super(executor);
okHttpClient = options
.plus(clientBuilder.get().dispatcher(createDispatcher(executor, maxRequests, maxRequestsPerHost)))
.build();
}

```

The second constructor doesn't reuse the passed `executorService` when creating the dispatcher, while all others that get the same argument do.

It just so happens that this one would be the ideal one for us 🤠.

Is there a reason for this, or is it an oversight?

Besides this, any thoughts or recommendations on using the Virtual Threads executor with the SDK?
Maybe you've already done experimenting on your end? Is the SDK prone to [Thread Pinning](https://docs.oracle.com/en/java/javase/21/core/virtual-threads.html#GUID-704A716D-0662-4BC7-8C7F-66EE74B1EDAD)?

Thanks.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.