commandlineparser / commandlineparser/commandline
DashDash (--) doesn't work properly with multi-value options
- Dominant language
- C#
- Stars
- 4.8k
- Forks
- 478
- PR merge metrics
- No merged PRs in 30d
Description
When using the "DashDash" feature, the results are unexpected when using a multi-valued option.
## Single-valued option (base case)
`Program.cs`
```C#
class Program
{
#region Main
static int Main(string[] args)
{
return new Parser(with => with.EnableDashDash = true)
.ParseArguments(args)
.MapResult(options => RunWrappedExecutable(options),
_ => -2);
}
#endregion
}
```
`CommandLineOptions.cs`
```C#
class CommandLineOptions
{
#region Properties
[Option('o', "option")]
public string Option { get; set; }
[Value(0)]
public IEnumerable Values { get; set; }
#endregion
}
```
Running the program as follows:
```
foo.exe -o "option" -- value1 value2 value3
```
produces the (expected) results:
```
options.Option = "option"
options.Values = [ "value1", "value2", "value3" ]
```
## Multi-valued option (broken case)
`CommandLineOptions.cs`
```C#
class CommandLineOptions
{
#region Properties
[Option('o', "option")]
public IEnumerable Option { get; set; }
[Value(0)]
public IEnumerable Values { get; set; }
#endregion
}
```
Running the program as follows:
```
foo.exe -o "option" -- value1 value2 value3
```
produces the (unexpected) results:
```
options.Option = [ "option", "value1", "value2", "value3" ]
options.Values = [ ]
```
## Conclusion
My expectation is that any arguments after the `--` would be processed as values, rather than options. Can you confirm my expectations match yours? If so, I'm happy to try to resolve this issue and submit a PR. Thanks!
Contributor guide
No contributing guide indexed for this repository
Research direction
Reproduce the command shown in Program.cs using the multi-valued option in CommandLineOptions.cs, with EnableDashDash enabled. Trace the parser entry point that handles the -- separator and compare the single-valued and IEnumerable cases. Done means arguments after -- populate Values while the option retains only its preceding value, with a regression test covering the example.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100