commandlineparser / commandlineparser/commandline
Why does ParserSettings implement IDisposable?
- Dominant language
- C#
- Stars
- 4.8k
- Forks
- 478
- PR merge metrics
- No merged PRs in 30d
Description
Why does `ParserSettings` implement `IDisposable` while it disposes of nothing?
Is that because it [used to dispose of `HelpWriter`](https://github.com/commandlineparser/commandline/commit/c75a69abadd02daf984fb63e4256e3e4714d8345#diff-00a389261204bf2e245786d84442cfacR181) and you are not able to get rid of the interface without breaking the API?
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by inspecting ParserSettings and the linked historical commit showing its former HelpWriter disposal. Trace the public API usage to determine whether removing IDisposable would break compatibility. Done means documenting the compatibility decision and defining a concrete follow-up change, if one is warranted.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100