coding-blocks / coding-blocks/codingblocks.online.projectx

We need to scroll to the top of the page, when showing pages

Aperta
#418 2 commenti 1 reazione 0 assegnatari Vedi su GitHub
BOSS BOUNTY: 100
Lingua principale
JavaScript
Stelle
31
Fork
102
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

By Default, the scroll position is preserved while transitioning routes. However, at times this isn't the desired behaviour.
We need to scroll to top for the following pages:

- [ ] Home
- [ ] All Courses
- [ ] My Courses
- [ ] Course Timeline (Course Overview)
- [ ] Course/:id

### How ?
Use [ember-router-scroll](https://github.com/dollarshaveclub/ember-router-scroll) plugin, and use the mixin at the mentioned routes.

Don't `window.scrollTop(0, 0)` in beforeModel or similar hook. This will not preserve scroll position when using browser's back button. #DontBreakTheWeb

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.