codex-team / codex-team/editor.js

The Inline Toolbar no longer allows multiple custom input tools

Offen
#2,829 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
questionable
Vorherrschende Sprache
TypeScript
Sterne
31.9k
Forks
2.2k
Ø Merge
1 T. 1 Std.
Gemergte PRs (30 T.)
1

Beschreibung

The new inline toolbar breaks our implementation of inline tools that are custom inputs instead of toggles.

Previously you could have multiple inline tools that opened custom inputs because each tool would open in a long list one after the other. But the recent updates make it so you can have only 1 of these custom inputs active at a time, and if you select another one it will toggle off your current selection.

For example, I wouldn't be able to have a custom link AND a custom text color/classname on this selection at the same time because it will automatically remove my current selection when I choose the other one.

![Screenshot 2024-09-26 at 12 12 21 PM](https://github.com/user-attachments/assets/291e3a82-789f-4478-a563-b1031e504f47)
![Screenshot 2024-09-26 at 12 11 05 PM](https://github.com/user-attachments/assets/6d1eeba2-a206-4334-ab3c-8a25874d826d)

The documentation isn't up to date for these changes, is there a way to remove this behaviour or fix this issue?

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Rechercherichtung

Start by reproducing the issue with two custom inline input tools, such as a link and a text color or classname tool, and inspect the inline toolbar implementation. Compare the current behavior with the older long-list behavior and review the inline tool documentation. Done means multiple custom inputs can remain active on the same selection without toggling one another off, with documentation updated to match.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
typescript
Bereich
frontend
Issue-Typ
Bug
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
35/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.