codex-team / codex-team/editor.js

[bug] onChange is thrown infinitely with image-simple and mermaid plugins

Aperta
#2,139 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
bug
Lingua principale
TypeScript
Stelle
31.9k
Fork
2.2k
Merge medio
1g 1h
PR unite (30g)
1

Descrizione

I'm working on a editorjs app synced by Yjs.
it seems to work great with most of the plugins. and sync is reported to other users, but with two plugins (image-simple & mermaid), the onChange function seems to be thrown every second .
I use the onChange function to save the editor content to a yMap of Yjs

The issue is that each of the two users, get infinite refresh of the page.

is this onChange event thrown by the editor or by the concerned plugins ? is this an issue for each plugin ?

my editor code is here https://github.com/scenaristeur/noosphere/blob/main/src/views/EditorView.vue
see demo video and working app at https://scenaristeur.github.io/noosphere/about

https://user-images.githubusercontent.com/4020744/189363842-d732cdf5-f988-46bc-9919-2d83e89ebaa2.mp4

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.