coderedcorp / coderedcorp/coderedcms
Use correct site when loading settings
Open
Area: Multisite 🏨
Type: Tech Debt
- Dominant language
- Python
- Stars
- 765
- Forks
- 154
- PR merge metrics
- No merged PRs in 30d
Description
When loading wagtail settings, such as `GoogleApiSettings` or `MailchimpApiSettings` we have a tendency to do these in a place where no `Site` is available and explicitly load the default site. This is a bad practice as it totally breaks the concept of multi-site.
This practice needs to be refactored to get the site from the page or request, and if those are not available, use dependency injection techniques.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.