coder / coder/websocket

Update docs and mention explicit close required change in v1.8.11

未关闭
#445 16 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Go
星标
5.5k
派生
372
PR 合并指标
30 天内没有已合并 PR

描述

## Problem
In our production systems we upgraded to latest patch version and we noticed excessive memory usage, seemed to be goroutine leak as far as I checked. Memory went up but when connections count went down, memory stayed roughly at the same level.

Probably on `close` etc it was not cleaned up properly, but I did not dig any further - for now we rolled back to version `v1.8.10` and all is back to normal.

Our use-case:
We have roughly opened 50k websockets on peak time at day, 500 messages pushed per second, 30 new websockets made per second, 30 old websockets closed per second.

Also for each websocket connection we execute in separate goroutine `PING-PONG`er to prevent websockets closing for clients under some circumstances.

Maybe it's some edge case with our usage, but for us it seems regression introduced.
If I can help anyhow more then let me know 🙏

贡献指南

这个仓库没有索引到贡献指南

调研方向

Start by reviewing the v1.8.11 change related to connection closing and the existing documentation for WebSocket lifecycle management. Update the relevant documentation to mention that callers must explicitly close connections, then verify that the v1.8.11 behavior and requirement are described accurately.

由索引模型根据 Issue 内容生成。

评估

技术栈
go
领域
documentation
Issue 类型
文档
难度
2/5
预计耗时
1-3 小时
活跃度
停滞
描述清晰度
需要澄清
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。