Add ReadLimit to Option structs
- Dominant language
- Go
- Stars
- 5.5k
- Forks
- 372
- PR merge metrics
- No merged PRs in 30d
Description
Would it be possible to add a field to `AcceptOptions` and to `DialOptions` that sets the read limit on the created connection? It's not as convenient to have to call the `SetReadLimit()`. If the field is 0 then a default limit can be applied.
Is there a need to change the limit dynamically? I mean, why is it a method (i.e. can be called multiple times) vs a field in those option setting structs?
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating the AcceptOptions and DialOptions definitions and the SetReadLimit method, then trace how each option creates a connection. Determine how a zero-valued field should interact with the default limit and whether the method must remain usable for dynamic changes. Done means both option structs can configure the initial read limit without removing the existing method behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend-api-design, networking
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100