coder / coder/websocket

Add ReadLimit to Option structs

Open
#244 9 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Go
Stars
5.5k
Forks
372
PR merge metrics
No merged PRs in 30d

Description

Would it be possible to add a field to `AcceptOptions` and to `DialOptions` that sets the read limit on the created connection? It's not as convenient to have to call the `SetReadLimit()`. If the field is 0 then a default limit can be applied.

Is there a need to change the limit dynamically? I mean, why is it a method (i.e. can be called multiple times) vs a field in those option setting structs?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.