coder / coder/vscode-coder

Start workspace without asking when pressing the play button

未关闭
#331 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
TypeScript
星标
130
派生
48
平均合并
3 天 3 小时
30 天内合并 PR
15

描述

Currently, the play button immediately calls out to the remote SSH plugin.

Then, our plugin hooks into the remote SSH plugin activation and it does its magic like starting the workspace.

Problem is, we cannot tell if the remote SSH plugin was activated due to the play button being pressed or due to a reconnect. We cannot auto-start on reconnects because it causes issues with auto-stopped workspaces (VS Code will keep reconnecting and keep turning workspaces on, preventing the cost savings).

So, assuming there is no clever way to tell what caused the connect, I think we will just have to duplicate the start code when you press that button. Then delegate to the remote SSH plugin.

Another case where you probably want the workspace to start without asking is from the recents menu, but that goes straight to the remote SSH plugin so I am not sure there is anything we can do there. Is there some way in the remote authority activation hook to tell what caused the connect? If we can distinguish between a first connect and a reconnect, that would be ideal.

Another case is when coming in from the dashboard. This could be handled like the play button by duplicating the start code.

贡献指南

打开贡献指南

调研方向

跟踪 play-button、dashboard 和 recents 入口点,以及远程 SSH 插件激活钩子。首先确定该钩子是否能够区分初始连接和重新连接。完成的标准是:通过 play-button 和 dashboard 启动时,工作区无需提示即可启动,而重新连接不会自动启动已自动停止的工作区。

由索引模型根据 Issue 内容生成。

评估

技术栈
typescript
领域
developer-experience, devtools
Issue 类型
功能
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。