coder / coder/vscode-coder

Start workspace without asking when pressing the play button

Open
#331 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
130
Forks
48
Avg merge
3d 3h
Merged PRs (30d)
15

Description

Currently, the play button immediately calls out to the remote SSH plugin.

Then, our plugin hooks into the remote SSH plugin activation and it does its magic like starting the workspace.

Problem is, we cannot tell if the remote SSH plugin was activated due to the play button being pressed or due to a reconnect. We cannot auto-start on reconnects because it causes issues with auto-stopped workspaces (VS Code will keep reconnecting and keep turning workspaces on, preventing the cost savings).

So, assuming there is no clever way to tell what caused the connect, I think we will just have to duplicate the start code when you press that button. Then delegate to the remote SSH plugin.

Another case where you probably want the workspace to start without asking is from the recents menu, but that goes straight to the remote SSH plugin so I am not sure there is anything we can do there. Is there some way in the remote authority activation hook to tell what caused the connect? If we can distinguish between a first connect and a reconnect, that would be ideal.

Another case is when coming in from the dashboard. This could be handled like the play button by duplicating the start code.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.