coder / coder/vscode-coder

Split remote.ts by topic, starting with migrations

未关闭
#1,066 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Improvement tech-debt vs-code
主要语言
TypeScript
星标
130
派生
48
平均合并
3 天 3 小时
30 天内合并 PR
15

描述

\`src/remote/remote.ts\` is 1,207 lines and mixes every concern of remote setup in one class. Recent work (per-editor SSH configs, legacy authority migration) keeps growing it.

## Topics currently mixed into the class

- Setup orchestration: \`setup\`, \`setupCoderRemote\`
- Migrations: \`migrateLegacyAuthority\` (authority), \`migrateToSecretsStorage\`, \`migrateSessionTokenFile\`, \`migrateSessionAuthFromFiles\` (credentials)
- SSH config assembly: \`updateSSHConfig\`, \`writeRemoteSshConfig\`, \`buildProxyCommand\`, \`getSshConfigPath\`, \`getLogArgs\`, \`getLogDir\`
- Workspace lifecycle: \`lookupWorkspace\`, \`waitForWorkspaceReady\`, \`resolveAgent\`
- Auth/session: \`ensureLoggedInAndRetry\`, \`showSessionExpiredDialog\`, \`watchRemoteSessionAuth\`
- Binary management: \`resolveRemoteBinary\`, \`checkCompatibility\`
- Window/UI glue: \`createAgentMetadataStatusBar\`, \`watchSettings\`, \`registerLabelFormatter\`, \`closeRemote\`, \`reloadWindow\`

## Proposal

1. Extract migrations first, e.g. into \`src/remote/migrations.ts\`. They are self-contained, interact little with the rest of setup, and each has a deletion horizon; keeping them together makes them easy to find and eventually remove.
2. If that lands well, extract SSH config assembly next. It is the most test-heavy area and only needs the path resolver, settings, and logger.
3. Keep orchestration (\`setup\`/\`setupCoderRemote\`) in \`remote.ts\`.

Non-goals: no behavior changes and no new abstractions; move plain methods by topic and keep the telemetry span threading as is.

Filed by Claude Code for @EhabY.

贡献指南

打开贡献指南

调研方向

Start in src/remote/remote.ts by reading migrateLegacyAuthority, migrateToSecretsStorage, migrateSessionTokenFile, and migrateSessionAuthFromFiles, along with their callers in setup and setupCoderRemote. Extract these plain methods into src/remote/migrations.ts while preserving behavior, deletion horizons, and telemetry span threading; the migration flow should continue to work unchanged.

由索引模型根据 Issue 内容生成。

评估

技术栈
typescript
领域
devtools
Issue 类型
重构
难度
3/5
预计耗时
1-2 天
活跃度
冷清
描述清晰度
基本清楚
新手友好度
55/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。