coder / coder/internal

Implement notifications RBAC role

Aperta
#2 2 commenti 0 reazioni 1 assegnatario Rivendicata da @dannykopping Vedi su GitHub
project/notifications
Lingua principale
Nessun dato sulla lingua
Stelle
3
Fork
0
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

There are a number of TODOs in the `notifications` package around RBAC.

@Emyrk gave us some pointers on how to implement this:

> Add a new resource like template here: https://github.com/coder/coder/blob/769ac83729fb642d61538f871889d5161e0136fa/coderd/rbac/policy/policy.go#L130-L139
It will autogen in some files.
Copy this RBACObject from File pretty much exactly:
https://github.com/coder/coder/blob/769ac83729fb642d61538f871889d5161e0136fa/coderd/database/modelmethods.go#L208-L212

---

> With those 2 things, the rbac should just work. As all users by default get allPermsExcept() here: https://github.com/coder/coder/blob/769ac83729fb642d61538f871889d5161e0136fa/coderd/rbac/roles.go#L246-L246
So the notificaton resource will be appended automatically. The WithOwner() scopes the resource to the user

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.