coder / coder/coder-desktop-windows

Some SVG features aren't supported for SVG app icons

Ouverte
#92 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
C#
Étoiles
26
Forks
12
Merge moyen
6 h 50 min
PR mergées (30 j)
1

Description

### Embedded bitmaps

Some SVG files are actually PNGs masquerading as SVGs.

Take for example `/icon/cursor.svg` in Coder:
```svg

```

WinUI 3's `SvgImageSource` doesn't seem to be able to render `` tags like these in SVGs, so `cursor.svg` shows up as blank.

There's no way to detect that it failed to render as it fails silently.

### VS Code Icon gradient

The VS Code icon `/icon/code.svg` has a weird white gradient over it in the app that doesn't appear when viewing the SVG in a web browser.

![Image](https://github.com/user-attachments/assets/4ace5cbd-97ca-4a96-a275-3bcceedfe0a1)

-----

We could fix all of the SVGs in Coder and just declare that the desktop app for windows can't render icons like these somewhere in our documentation or something, or we could parse the SVG to look for these tags and try to render as a `BitmapImage` instead.

Relates to #91

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Piste de recherche

Start by tracing the Windows desktop app's SVG icon loading through WinUI 3's SvgImageSource, using /icon/cursor.svg and /icon/code.svg as reproduction cases. Check how embedded elements and gradients are handled, then verify that affected icons render correctly without silent failure.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
csharp
Domaine
desktop
Type d'issue
Bug
Difficulté
4/5
Temps estimé
3-5 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
35/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.