coder / coder/coder-desktop-windows

Some SVG features aren't supported for SVG app icons

Open
#92 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
26
Forks
12
Avg merge
6h 50m
Merged PRs (30d)
1

Description

### Embedded bitmaps

Some SVG files are actually PNGs masquerading as SVGs.

Take for example `/icon/cursor.svg` in Coder:
```svg

```

WinUI 3's `SvgImageSource` doesn't seem to be able to render `` tags like these in SVGs, so `cursor.svg` shows up as blank.

There's no way to detect that it failed to render as it fails silently.

### VS Code Icon gradient

The VS Code icon `/icon/code.svg` has a weird white gradient over it in the app that doesn't appear when viewing the SVG in a web browser.

![Image](https://github.com/user-attachments/assets/4ace5cbd-97ca-4a96-a275-3bcceedfe0a1)

-----

We could fix all of the SVGs in Coder and just declare that the desktop app for windows can't render icons like these somewhere in our documentation or something, or we could parse the SVG to look for these tags and try to render as a `BitmapImage` instead.

Relates to #91

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.